From: Dennis Maisenbacher <dennis.maisenbacher@wdc.com>
Date: Fri, 8 Nov 2024 08:10:26 +0000 (+0000)
Subject: tests: Remove unneeded sleep statements
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=94924df7ec34add56b09d6eb6cf8490963860349;p=users%2Fsagi%2Fnvme-cli.git

tests: Remove unneeded sleep statements

Removing sleep statements, which improves the test cases runtime.

Signed-off-by: Dennis Maisenbacher <dennis.maisenbacher@wdc.com>
---

diff --git a/tests/nvme_attach_detach_ns_test.py b/tests/nvme_attach_detach_ns_test.py
index a0e6129d..f2363008 100644
--- a/tests/nvme_attach_detach_ns_test.py
+++ b/tests/nvme_attach_detach_ns_test.py
@@ -29,8 +29,6 @@ NVMe Namespace Management Testcase:-
     5. Delete Namespace.
 """
 
-import time
-
 from nvme_test import TestNVMe
 
 
@@ -59,7 +57,6 @@ class TestNVMeAttachDetachNSCmd(TestNVMe):
         self.setup_log_dir(self.__class__.__name__)
         self.ctrl_id = self.get_ctrl_id()
         self.delete_all_ns()
-        time.sleep(1)
 
     def tearDown(self):
         """
diff --git a/tests/nvme_create_max_ns_test.py b/tests/nvme_create_max_ns_test.py
index 76cd4d4a..5cb7448e 100644
--- a/tests/nvme_create_max_ns_test.py
+++ b/tests/nvme_create_max_ns_test.py
@@ -29,8 +29,6 @@ NVMe Namespace Management Testcase:-
     5. Delete all Namespaces.
 """
 
-import time
-
 from nvme_test import TestNVMe
 
 
@@ -63,7 +61,6 @@ class TestNVMeCreateMaxNS(TestNVMe):
         self.max_ns = self.get_max_ns()
         self.ctrl_id = self.get_ctrl_id()
         self.delete_all_ns()
-        time.sleep(1)
 
     def tearDown(self):
         """
diff --git a/tests/nvme_format_test.py b/tests/nvme_format_test.py
index 9faf3dc8..daf35740 100644
--- a/tests/nvme_format_test.py
+++ b/tests/nvme_format_test.py
@@ -40,7 +40,6 @@ Namespace Format testcase :-
 import json
 import math
 import subprocess
-import time
 
 from nvme_test import TestNVMe
 
@@ -76,7 +75,6 @@ class TestNVMeFormatCmd(TestNVMe):
         self.test_log_dir = self.log_dir + "/" + self.__class__.__name__
         self.setup_log_dir(self.__class__.__name__)
         self.delete_all_ns()
-        time.sleep(1)
 
     def tearDown(self):
         """
diff --git a/tests/nvme_test.py b/tests/nvme_test.py
index 0bd10f55..8088ee2e 100644
--- a/tests/nvme_test.py
+++ b/tests/nvme_test.py
@@ -30,7 +30,6 @@ import shutil
 import stat
 import subprocess
 import sys
-import time
 import unittest
 
 from nvme_test_logger import TestNVMeLogger
@@ -165,14 +164,12 @@ class TestNVMe(unittest.TestCase):
                               stdout=subprocess.PIPE,
                               encoding='utf-8')
         self.assertEqual(err, 0, "ERROR : nvme reset failed")
-        time.sleep(5)
         rescan_cmd = "echo 1 > /sys/bus/pci/rescan"
         proc = subprocess.Popen(rescan_cmd,
                                 shell=True,
                                 stdout=subprocess.PIPE,
                                 stderr=subprocess.PIPE,
                                 encoding='utf-8')
-        time.sleep(5)
         self.assertEqual(proc.wait(), 0, "ERROR : pci rescan failed")
 
     def get_ctrl_id(self):
@@ -385,7 +382,6 @@ class TestNVMe(unittest.TestCase):
         """
         err = self.create_ns(nsze, ncap, flbas, dps)
         if err == 0:
-            time.sleep(2)
             id_ns_cmd = f"{self.nvme_bin} id-ns {self.ctrl} " + \
                 f"--namespace-id={str(nsid)}"
             err = subprocess.call(id_ns_cmd,
@@ -408,11 +404,9 @@ class TestNVMe(unittest.TestCase):
                               shell=True,
                               stdout=subprocess.PIPE,
                               encoding='utf-8')
-        time.sleep(5)
         if err == 0:
             # enumerate new namespace block device
             self.nvme_reset_ctrl()
-            time.sleep(5)
             # check if new namespace block device exists
             err = 0 if stat.S_ISBLK(os.stat(self.ns1).st_mode) else 1
         return err