From: Eryu Guan Date: Sun, 21 Feb 2016 23:38:44 +0000 (-0500) Subject: ext4: iterate over buffer heads correctly in move_extent_per_page() X-Git-Tag: v4.1.12-92~150^2~91 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=939cca6134737c3b17c9b2e29beb570d6640ed3e;p=users%2Fjedix%2Flinux-maple.git ext4: iterate over buffer heads correctly in move_extent_per_page() Orabug: 23331057 [ Upstream commit 87f9a031af48defee9f34c6aaf06d6f1988c244d ] In commit bcff24887d00 ("ext4: don't read blocks from disk after extents being swapped") bh is not updated correctly in the for loop and wrong data has been written to disk. generic/324 catches this on sub-page block size ext4. Fixes: bcff24887d00 ("ext4: don't read blocks from disk after extentsbeing swapped") Signed-off-by: Eryu Guan Signed-off-by: Theodore Ts'o Cc: stable@vger.kernel.org Signed-off-by: Sasha Levin (cherry picked from commit 31a37d7c7ef7b4f90b600fcddd1c385a39f9d34c) Signed-off-by: Dan Duval --- diff --git a/fs/ext4/move_extent.c b/fs/ext4/move_extent.c index 7da8ac1047f8..3fb92abe5707 100644 --- a/fs/ext4/move_extent.c +++ b/fs/ext4/move_extent.c @@ -393,6 +393,7 @@ data_copy: *err = ext4_get_block(orig_inode, orig_blk_offset + i, bh, 0); if (*err < 0) break; + bh = bh->b_this_page; } if (!*err) *err = block_commit_write(pagep[0], from, from + replaced_size);