From: Darrick J. Wong <darrick.wong@oracle.com>
Date: Wed, 24 Jan 2018 23:53:35 +0000 (-0800)
Subject: generic/403: don't spew '$GETFATTR_PROG: Killed' messages
X-Git-Tag: v2022.05.01~1677
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=9385d3a90113d3af6315ddf41be5f8fe6ee0fb30;p=users%2Fhch%2Fxfstests-dev.git

generic/403: don't spew '$GETFATTR_PROG: Killed' messages

Use a runfile presence check to control the background getfattr loop
instead of using kill -9.  This helps us to avoid the problem that
the controlling bash will print a process killed message, which
wrecks the golden output.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Eryu Guan <eguan@redhat.com>
Signed-off-by: Eryu Guan <eguan@redhat.com>
---

diff --git a/tests/generic/403 b/tests/generic/403
index 17897ffb0..31c481b4e 100755
--- a/tests/generic/403
+++ b/tests/generic/403
@@ -61,7 +61,9 @@ touch $SCRATCH_MNT/file
 $SETFATTR_PROG -n trusted.small -v a $SCRATCH_MNT/file
 
 # start a background getxattr loop for the existing xattr
-while [ true ]; do
+runfile="$tmp.getfattr"
+touch $runfile
+while [ -e $runfile ]; do
 	$GETFATTR_PROG --absolute-names -n trusted.small $SCRATCH_MNT/file \
 		> /dev/null || break
 done &
@@ -75,7 +77,7 @@ for i in $(seq 0 99); do
 	$SETFATTR_PROG -x trusted.big $SCRATCH_MNT/file
 done
 
-kill -9 $getfattr_pid > /dev/null 2>&1
+rm -f $runfile
 wait > /dev/null 2>&1
 
 echo Silence is golden