From: Li Zetao Date: Tue, 3 Sep 2024 14:38:12 +0000 (+0800) Subject: pinctrl: Remove redundant null pointer checks in pinctrl_remove_device_debugfs() X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=92f4368347a2a8a204b0513df32233075cd93b4f;p=users%2Fjedix%2Flinux-maple.git pinctrl: Remove redundant null pointer checks in pinctrl_remove_device_debugfs() Since the debugfs_create_dir() never returns a null pointer, checking the return value for a null pointer is redundant, and using IS_ERR is safe enough. Signed-off-by: Li Zetao Link: https://lore.kernel.org/20240903143812.2005071-1-lizetao1@huawei.com Signed-off-by: Linus Walleij --- diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c index 314ab93d76918..4061890a17483 100644 --- a/drivers/pinctrl/core.c +++ b/drivers/pinctrl/core.c @@ -1971,7 +1971,7 @@ static void pinctrl_remove_device_debugfs(struct pinctrl_dev *pctldev) static void pinctrl_init_debugfs(void) { debugfs_root = debugfs_create_dir("pinctrl", NULL); - if (IS_ERR(debugfs_root) || !debugfs_root) { + if (IS_ERR(debugfs_root)) { pr_warn("failed to create debugfs directory\n"); debugfs_root = NULL; return;