From: Christoph Hellwig <hch@lst.de>
Date: Tue, 7 Jun 2022 08:05:47 +0000 (+0200)
Subject: rewrite the "Volume Identification" ѕection
X-Git-Tag: draft-hellwig-nfsv4-scsi-layout-nvme-03~20
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=9248520f22703a03695ab752228b02c1ae5acb8e;p=users%2Fhch%2Fscsi-layout-nvme.git

rewrite the "Volume Identification" ѕection

Pull in the few bits of information that we actually need instead of
relying on the STLR whitepaper.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---

diff --git a/scsi_nvme_middle.xml b/scsi_nvme_middle.xml
index cd9b5bc..a4f078f 100644
--- a/scsi_nvme_middle.xml
+++ b/scsi_nvme_middle.xml
@@ -75,17 +75,34 @@
     <t>
       The pNFS SCSI layout uses the Device Identification VPD page (page code
       0x83) from <xref target="SPC4" /> to identify the devices used by
-      a layout.  Section 6.1.4 of <xref target="NVME-STLR" /> lists ways
-      to build SCSI Device Identification descriptors from NVMe Identify
-      data.
+      a layout. Implementation using NVMe device shall use a mapping from
+      NVMe identifier to the SPC Device Identification VPD page that is
+      compatible to that defined in Section 6.1.4 of
+      <xref target="NVME-STLR" />.
+    </t>
 
+    <t>
       To be used as storage devices for the pNFS SCSI layout, NVMe devices
       MUST support either the EUI64 or NGUID value in the
       Identify Namespace data, as the methods based on the Serial Number for
       legacy devices might not be suitable for unique addressing needs and
-      thus MUST NOT be used.  If possible NVMe devices uses as storage
-      devices for the pNFS SCSI layout SHOULD support the NGUID value as
-      it is the larger identifier.
+      thus MUST NOT be used.  If available, the NGUID value SHOULD be used
+      as the larger identifier.
+      <!-- XXX also allow the Identifier descriptors -->
+    </t>
+
+    <t>
+      The pnfs_scsi_base_volume_info4 structure shall be constructed as
+      following:
+      <list style='numbers'>
+      <t>The "sbv_code_set" field SHALL be set to PS_CODE_SET_BINARY.</t>
+      <t>The "pnfs_scsi_designator_type" field SHALL be set to
+         PS_DESIGNATOR_EUI64.</t>
+      <t>The "sbv_designator" field shall contain either the NGUID or EUI64
+         fields from the Identify Namespace data.</t>
+      <!-- XXX: add a reference to the persistent reservation section for
+           sbv_pr_key -->
+      </list>
     </t>
   </section>