From: Chuck Lever <chuck.lever@oracle.com>
Date: Tue, 7 Jun 2022 20:48:05 +0000 (-0400)
Subject: SUNRPC: Clean up xdr_commit_encode()
X-Git-Tag: v5.19-rc2~11^2~2
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=90d871b3b9bb7ef8f835d6b53095f01b9c74b7b3;p=users%2Fdwmw2%2Flinux.git

SUNRPC: Clean up xdr_commit_encode()

Both the kvec::iov_len field and the third parameter of memcpy() and
memmove() are size_t. There's no reason for the implicit conversion
from size_t to int and back. Change the type of @shift to make the
code easier to read and understand.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Reviewed-by: NeilBrown <neilb@suse.de>
Reviewed-by: J. Bruce Fields <bfields@fieldses.org>
---

diff --git a/net/sunrpc/xdr.c b/net/sunrpc/xdr.c
index 1ad8b4ef14de7..3c182041e790d 100644
--- a/net/sunrpc/xdr.c
+++ b/net/sunrpc/xdr.c
@@ -933,7 +933,7 @@ EXPORT_SYMBOL_GPL(xdr_init_encode);
  */
 void __xdr_commit_encode(struct xdr_stream *xdr)
 {
-	int shift = xdr->scratch.iov_len;
+	size_t shift = xdr->scratch.iov_len;
 	void *page;
 
 	page = page_address(*xdr->page_ptr);