From: Zijun Hu Date: Sat, 24 Aug 2024 09:07:43 +0000 (+0800) Subject: driver core: Make parameter check consistent for API cluster device_(for_each|find... X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=903c44939abc02e2f3d6f2ad65fa090f7e5df5b6;p=users%2Fjedix%2Flinux-maple.git driver core: Make parameter check consistent for API cluster device_(for_each|find)_child() The following API cluster takes the same type parameter list, but do not have consistent parameter check as shown below. device_for_each_child(struct device *parent, ...) // check (!parent->p) device_for_each_child_reverse(struct device *parent, ...) // same as above device_find_child(struct device *parent, ...) // check (!parent) Fixed by using consistent check (!parent || !parent->p) which covers both existing checks for the cluster. Signed-off-by: Zijun Hu Link: https://lore.kernel.org/r/20240824-const_dfc_prepare-v3-1-32127ea32bba@quicinc.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/base/core.c b/drivers/base/core.c index 6113bc1092aea..b69b82da8837e 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -3998,7 +3998,7 @@ int device_for_each_child(struct device *parent, void *data, struct device *child; int error = 0; - if (!parent->p) + if (!parent || !parent->p) return 0; klist_iter_init(&parent->p->klist_children, &i); @@ -4028,7 +4028,7 @@ int device_for_each_child_reverse(struct device *parent, void *data, struct device *child; int error = 0; - if (!parent->p) + if (!parent || !parent->p) return 0; klist_iter_init(&parent->p->klist_children, &i); @@ -4062,7 +4062,7 @@ struct device *device_find_child(struct device *parent, void *data, struct klist_iter i; struct device *child; - if (!parent) + if (!parent || !parent->p) return NULL; klist_iter_init(&parent->p->klist_children, &i);