From: Jakub Kicinski Date: Sun, 15 Dec 2019 01:16:12 +0000 (-0800) Subject: Merge branch 'gtp-fix-several-bugs-in-gtp-module' X-Git-Tag: v5.5-rc3~7^2~42 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=8ed001c966b0dd812a1cc57ae4b9c7b6d1454a25;p=users%2Fwilly%2Fxarray.git Merge branch 'gtp-fix-several-bugs-in-gtp-module' Taehee Yoo says: ==================== gtp: fix several bugs in gtp module This patchset fixes several bugs in the GTP module. 1. Do not allow adding duplicate TID and ms_addr pdp context. In the current code, duplicate TID and ms_addr pdp context could be added. So, RX and TX path could find correct pdp context. 2. Fix wrong condition in ->dumpit() callback. ->dumpit() callback is re-called if dump packet size is too big. So, before return, it saves last position and then restart from last dump position. TID value is used to find last dump position. GTP module allows adding zero TID value. But ->dumpit() callback ignores zero TID value. So, dump would not work correctly if dump packet size too big. 3. Fix use-after-free in ipv4_pdp_find(). RX and TX patch always uses gtp->tid_hash and gtp->addr_hash. but while packet processing, these hash pointer would be freed. So, use-after-free would occur. 4. Fix panic because of zero size hashtable GTP hashtable size could be set by user-space. If hashsize is set to 0, hashtable will not work and panic will occur. ==================== Signed-off-by: Jakub Kicinski --- 8ed001c966b0dd812a1cc57ae4b9c7b6d1454a25