From: Tian Tao <tiantao6@hisilicon.com>
Date: Tue, 29 Dec 2020 08:55:30 +0000 (+0100)
Subject: media: vidtv: Use kmemdup instead of kzalloc and memcpy
X-Git-Tag: howlett/maple/20220722_2~3757^2~137
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=8d23ada8e72d460c24da50a008209ecd3d7f9c8b;p=users%2Fjedix%2Flinux-maple.git

media: vidtv: Use kmemdup instead of kzalloc and memcpy

Fixes coccicheck warning:
drivers/media/test-drivers/vidtv/vidtv_psi.c:509:10-17: WARNING
opportunity for kmemdup

Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---

diff --git a/drivers/media/test-drivers/vidtv/vidtv_psi.c b/drivers/media/test-drivers/vidtv/vidtv_psi.c
index 1724bb485e67..47ed7907db8d 100644
--- a/drivers/media/test-drivers/vidtv/vidtv_psi.c
+++ b/drivers/media/test-drivers/vidtv/vidtv_psi.c
@@ -506,10 +506,9 @@ struct vidtv_psi_desc *vidtv_psi_desc_clone(struct vidtv_psi_desc *desc)
 
 		case REGISTRATION_DESCRIPTOR:
 		default:
-			curr = kzalloc(sizeof(*desc) + desc->length, GFP_KERNEL);
+			curr = kmemdup(desc, sizeof(*desc) + desc->length, GFP_KERNEL);
 			if (!curr)
 				return NULL;
-			memcpy(curr, desc, sizeof(*desc) + desc->length);
 		}
 
 		if (!curr)