From: Sergio Paracuellos Date: Thu, 29 Nov 2018 18:39:55 +0000 (+0100) Subject: staging: mt7621-pci: add comment clarifying inverted reset lines X-Git-Tag: v5.0-rc1~97^2~183 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=8cfb722bd55ab3879486001797741e879fbc7095;p=users%2Fwilly%2Fxarray.git staging: mt7621-pci: add comment clarifying inverted reset lines To avoid people reading this code being very confused, add a comment clarifying the need for invert resets on some chip revisions. Suggested-by: Dan Carpenter Signed-off-by: Sergio Paracuellos Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c b/drivers/staging/mt7621-pci/pci-mt7621.c index c5e33fbdf225..31310b6fb7db 100644 --- a/drivers/staging/mt7621-pci/pci-mt7621.c +++ b/drivers/staging/mt7621-pci/pci-mt7621.c @@ -589,6 +589,10 @@ static int mt7621_pcie_init_port(struct mt7621_pcie_port *port) u32 slot = port->slot; u32 val = 0; + /* + * Any MT7621 Ralink pcie controller that doesn't have 0x0101 at + * the end of the chip_id has inverted PCI resets. + */ mt7621_reset_port(port); val = read_config(pcie, slot, PCIE_FTS_NUM);