From: Ville Syrjälä Date: Tue, 6 Mar 2018 16:48:46 +0000 (+0200) Subject: drm: WARN when trying to add enum value > 63 to a bitmask property X-Git-Tag: v4.17-rc1~185^2~16^2~17 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=8c6c2fe2f11b0f03be34efd1639ab921c8a4c163;p=users%2Fjedix%2Flinux-maple.git drm: WARN when trying to add enum value > 63 to a bitmask property Enum values >63 with a bitmask property is a programmer error. WARN when someone is attempting this. Signed-off-by: Ville Syrjälä Link: https://patchwork.freedesktop.org/patch/msgid/20180306164849.2862-3-ville.syrjala@linux.intel.com Reviewed-by: Daniel Vetter --- diff --git a/drivers/gpu/drm/drm_property.c b/drivers/gpu/drm/drm_property.c index e676b1ecc705..019d1abb94ca 100644 --- a/drivers/gpu/drm/drm_property.c +++ b/drivers/gpu/drm/drm_property.c @@ -386,8 +386,8 @@ int drm_property_add_enum(struct drm_property *property, int index, * Bitmask enum properties have the additional constraint of values * from 0 to 63 */ - if (drm_property_type_is(property, DRM_MODE_PROP_BITMASK) && - (value > 63)) + if (WARN_ON(drm_property_type_is(property, DRM_MODE_PROP_BITMASK) && + value > 63)) return -EINVAL; list_for_each_entry(prop_enum, &property->enum_list, head) {