From: Jesper Juhl <jj@chaosbits.net>
Date: Thu, 12 Apr 2012 20:37:41 +0000 (-0500)
Subject: qla2xxx: Remove redundant NULL check before release_firmware() call.
X-Git-Tag: v2.6.39-400.9.0~459
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=8b8aa885c5770fba674abe71b98cc36b74d46304;p=users%2Fjedix%2Flinux-maple.git

qla2xxx: Remove redundant NULL check before release_firmware() call.

release_firmware() checks for NULL pointers internally so checking before calling it is redundant.

JIRA Key: V2632FC-196
---

diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
index 9c884a7506de..d897b3ad34f3 100644
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -4137,8 +4137,7 @@ qla2x00_release_firmware(void)
 
 	mutex_lock(&qla_fw_lock);
 	for (idx = 0; idx < FW_BLOBS; idx++)
-		if (qla_fw_blobs[idx].fw)
-			release_firmware(qla_fw_blobs[idx].fw);
+		release_firmware(qla_fw_blobs[idx].fw);
 	mutex_unlock(&qla_fw_lock);
 }