From: Yang Yingliang Date: Thu, 1 Dec 2022 12:27:05 +0000 (+0800) Subject: regulator: core: fix module refcount leak in set_supply() X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=89f19d11aad82780d1d065164e98a6c1cb04a817;p=users%2Fjedix%2Flinux-maple.git regulator: core: fix module refcount leak in set_supply() [ Upstream commit da46ee19cbd8344d6860816b4827a7ce95764867 ] If create_regulator() fails in set_supply(), the module refcount needs be put to keep refcount balanced. Fixes: e2c09ae7a74d ("regulator: core: Increase refcount for regulator supply's module") Signed-off-by: Yang Yingliang Link: https://lore.kernel.org/r/20221201122706.4055992-2-yangyingliang@huawei.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index 78b6469e74d52..bf418bc101469 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -1640,6 +1640,7 @@ static int set_supply(struct regulator_dev *rdev, rdev->supply = create_regulator(supply_rdev, &rdev->dev, "SUPPLY"); if (rdev->supply == NULL) { + module_put(supply_rdev->owner); err = -ENOMEM; return err; }