From: David Lechner Date: Wed, 26 Jun 2024 19:45:17 +0000 (-0500) Subject: spi: axi-spi-engine: remove platform_set_drvdata() X-Git-Tag: nvme-6.11-2024-08-08~140^2~13 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=89c2657429c4822a2697077bbb3a8d126d826ced;p=nvme.git spi: axi-spi-engine: remove platform_set_drvdata() platform_get_drvdata() is never called in the AXI SPI Engine driver, so platform_set_drvdata() is not needed. Remove it. This also lets us avoid the final error check in the probe function. Signed-off-by: David Lechner Reviewed-by: Nuno Sa Link: https://patch.msgid.link/20240626-spi-axi-spi-engine-remove-drvdata-v1-1-1752e372dd5d@baylibre.com Signed-off-by: Mark Brown --- diff --git a/drivers/spi/spi-axi-spi-engine.c b/drivers/spi/spi-axi-spi-engine.c index 3231f67ae265..03588fac9215 100644 --- a/drivers/spi/spi-axi-spi-engine.c +++ b/drivers/spi/spi-axi-spi-engine.c @@ -690,13 +690,7 @@ static int spi_engine_probe(struct platform_device *pdev) if (host->max_speed_hz == 0) return dev_err_probe(&pdev->dev, -EINVAL, "spi_clk rate is 0"); - ret = devm_spi_register_controller(&pdev->dev, host); - if (ret) - return ret; - - platform_set_drvdata(pdev, host); - - return 0; + return devm_spi_register_controller(&pdev->dev, host); } static const struct of_device_id spi_engine_match_table[] = {