From: Christoph Hellwig <hch@lst.de>
Date: Tue, 9 Jan 2024 15:45:47 +0000 (+0100)
Subject: minor fixes
X-Git-Tag: draft-ietf-nfsv4-scsi-layout-nvme-06
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=896eb8f32564054e84386a9eb96555cb27c749e5;p=users%2Fhch%2Fscsi-layout-nvme.git

minor fixes

From David Black
---

diff --git a/scsi-nvme.md b/scsi-nvme.md
index 0c91ffa..428e04c 100644
--- a/scsi-nvme.md
+++ b/scsi-nvme.md
@@ -170,7 +170,7 @@ when using the pNFS SCSI layout with NVMe namespaces.
 ## Volume Identification {#ssc:volident}
 
 The pNFS SCSI layout uses the Device Identification Vital Product Data (VPD)
-page (page code 0x83) from {{SPC5}} to identify the devices used by
+page (page code 83h) from {{SPC5}} to identify the devices used by
 a layout. Implementations that use NVMe namespaces as storage devices
 map NVMe namespace identifiers to a subset of the identifiers
 that the Device Identification VPD page supports for SCSI logical
@@ -181,8 +181,8 @@ MUST support either the IEEE Extended Unique Identifier (EUI64) or
 Namespace Globally Unique Identifier (NGUID) value reported in a Namespace
 Identification Descriptor, the I/O Command Set Independent Identify
 Namespace Data Structure, and the Identify Namespace Data Structure,
-NVM Command Set. If available, use of the NGUID value is preferred
-as it is the larger identifier.
+NVM Command Set {{NVME-BASE}}. If available, use of the NGUID value is
+preferred as it is the larger identifier.
 
 Note: The PS_DESIGNATOR_T10 and PS_DESIGNATOR_NAME have no equivalent
 in NVMe and cannot be used to identify NVMe storage devices.
@@ -200,8 +200,8 @@ SHALL be constructed as follows:
   identifiers are available, then the NGUID identifier SHOULD be
   used as it is the larger identifier.
 
-RFC 8154 specifies the "sbv_designator" field as an XDR variable length
-opaque\<>. The length of that XDR opaque\<> value (part of
+RFC 8154 {{RFC8154}} specifies the "sbv_designator" field as an XDR variable
+length opaque\<>. The length of that XDR opaque\<> value (part of
 its XDR representation) indicates which NVMe identifier is present.
 That length MUST be 16 octets for an NVMe NGUID identifier and
 MUST be 8 octets for an NVMe EUI64 identifier.  All other lengths
@@ -270,7 +270,7 @@ with the Reservation Acquire Action
 Abort), the Current Reservation Key (CRKEY) field set to the
 server's reservation key, the Preempt Reservation Key (PRKEY) field
 set to the reservation key associated with the non-responding client
-and the Reservation Type (RTYPE) field set to 010b (i.e., Exclusive
+and the Reservation Type (RTYPE) field set to 4h (i.e., Exclusive
 Access - Registrants Only Reservation).
 The client can distinguish I/O errors due to fencing from other
 errors based on the Reservation Conflict NVMe status code.