From: Pali Rohár Date: Mon, 30 Dec 2024 20:21:31 +0000 (+0100) Subject: cifs: Allow fallback code in smb_set_file_info() also for directories X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=88cae132dc0539ad188b787d32a7df4e16b5c1af;p=users%2Fhch%2Fmisc.git cifs: Allow fallback code in smb_set_file_info() also for directories On NT systems, it is possible to do SMB open call also for directories. Open argument CREATE_NOT_DIR disallows opening directories. So in fallback code path in smb_set_file_info() remove CREATE_NOT_DIR restriction to allow it also for directories. Similar fallback is implemented also in CIFSSMBSetPathInfoFB() function and this function already allows to call operation for directories. Signed-off-by: Pali Rohár Signed-off-by: Steve French --- diff --git a/fs/smb/client/smb1ops.c b/fs/smb/client/smb1ops.c index 3fdbb71036cf..7b17668e2a54 100644 --- a/fs/smb/client/smb1ops.c +++ b/fs/smb/client/smb1ops.c @@ -1032,7 +1032,7 @@ smb_set_file_info(struct inode *inode, const char *full_path, .tcon = tcon, .cifs_sb = cifs_sb, .desired_access = SYNCHRONIZE | FILE_WRITE_ATTRIBUTES, - .create_options = cifs_create_options(cifs_sb, CREATE_NOT_DIR), + .create_options = cifs_create_options(cifs_sb, 0), .disposition = FILE_OPEN, .path = full_path, .fid = &fid,