From: Al Viro Date: Sun, 28 Feb 2016 00:17:33 +0000 (-0500) Subject: do_last(): don't let a bogus return value from ->open() et.al. to confuse us X-Git-Tag: v4.1.12-92~150^2~150 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=88b4a2a3dacd7f677b029870636048efe343335e;p=users%2Fjedix%2Flinux-maple.git do_last(): don't let a bogus return value from ->open() et.al. to confuse us Orabug: stable_rc4 [ Upstream commit c80567c82ae4814a41287618e315a60ecf513be6 ] ... into returning a positive to path_openat(), which would interpret that as "symlink had been encountered" and proceed to corrupt memory, etc. It can only happen due to a bug in some ->open() instance or in some LSM hook, etc., so we report any such event *and* make sure it doesn't trick us into further unpleasantness. Cc: stable@vger.kernel.org # v3.6+, at least Signed-off-by: Al Viro Signed-off-by: Sasha Levin (cherry picked from commit 3960cde3e356057bd60adce1b625a7d178b9581c) Signed-off-by: Dan Duval --- diff --git a/fs/namei.c b/fs/namei.c index ccd7f98d85b9..438572278a9e 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -3152,6 +3152,10 @@ opened: goto exit_fput; } out: + if (unlikely(error > 0)) { + WARN_ON(1); + error = -EINVAL; + } if (got_write) mnt_drop_write(nd->path.mnt); path_put(&save_parent);