From: Philippe Mathieu-Daudé Date: Thu, 10 Oct 2019 13:15:27 +0000 (+0200) Subject: hw/misc/vmcoreinfo: Add comment about reset handler X-Git-Tag: pull-nvme-20200902~630^2~7 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=88552b16f2a11a51323b8a4d643e73332d89d7ef;p=qemu-nvme.git hw/misc/vmcoreinfo: Add comment about reset handler The VM coreinfo device does not sit on a bus, so it won't be reset automatically. This is why it calls qemu_register_reset(). Add a comment about it, so we don't convert its reset handler to a DeviceReset method. Reviewed-by: Marc-André Lureau Reviewed-by: Li Qiang Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20191010131527.32513-9-philmd@redhat.com> Signed-off-by: Eduardo Habkost --- diff --git a/hw/misc/vmcoreinfo.c b/hw/misc/vmcoreinfo.c index 326a3ce8f4..a9d718fc23 100644 --- a/hw/misc/vmcoreinfo.c +++ b/hw/misc/vmcoreinfo.c @@ -61,6 +61,10 @@ static void vmcoreinfo_realize(DeviceState *dev, Error **errp) NULL, fw_cfg_vmci_write, s, &s->vmcoreinfo, sizeof(s->vmcoreinfo), false); + /* + * This device requires to register a global reset because it is + * not plugged to a bus (which, as its QOM parent, would reset it). + */ qemu_register_reset(vmcoreinfo_reset, dev); vmcoreinfo_state = s; }