From: Jia-Ju Bai Date: Fri, 27 Jul 2018 02:45:30 +0000 (+0800) Subject: isdn: hisax: callc: Replace GFP_ATOMIC with GFP_KERNEL in init_PStack() X-Git-Tag: v4.19-rc1~140^2~236 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=87935aa776caae9c8346797271d19fa710b65a6a;p=users%2Fjedix%2Flinux-maple.git isdn: hisax: callc: Replace GFP_ATOMIC with GFP_KERNEL in init_PStack() init_PStack() is never called in atomic context. It calls kmalloc() with GFP_ATOMIC, which is not necessary. GFP_ATOMIC can be replaced with GFP_KERNEL. This is found by a static analysis tool named DCNS written by myself. Signed-off-by: Jia-Ju Bai Signed-off-by: David S. Miller --- diff --git a/drivers/isdn/hisax/callc.c b/drivers/isdn/hisax/callc.c index 5f43783039d4..9ee06328784c 100644 --- a/drivers/isdn/hisax/callc.c +++ b/drivers/isdn/hisax/callc.c @@ -1012,7 +1012,7 @@ dummy_pstack(struct PStack *st, int pr, void *arg) { static int init_PStack(struct PStack **stp) { - *stp = kmalloc(sizeof(struct PStack), GFP_ATOMIC); + *stp = kmalloc(sizeof(struct PStack), GFP_KERNEL); if (!*stp) return -ENOMEM; (*stp)->next = NULL;