From: Zqiang Date: Thu, 14 Apr 2022 06:06:51 +0000 (-0700) Subject: irq_work: use kasan_record_aux_stack_noalloc() record callstack X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=84d0640d64bc40ca0a751ead096f17bdc009efc0;p=users%2Fjedix%2Flinux-maple.git irq_work: use kasan_record_aux_stack_noalloc() record callstack [ 4.113128] BUG: sleeping function called from invalid context at kernel/locking/spinlock_rt.c:46 [ 4.113132] in_atomic(): 1, irqs_disabled(): 1, non_block: 0, pid: 239, name: bootlogd [ 4.113149] Preemption disabled at: [ 4.113149] [] rt_mutex_slowunlock+0xa1/0x4e0 [ 4.113154] CPU: 3 PID: 239 Comm: bootlogd Tainted: G W 5.17.1-rt17-yocto-preempt-rt+ #105 [ 4.113157] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS rel-1.15.0-0-g2dd4b9b3f840-prebuilt.qemu.org 04/01/2014 [ 4.113159] Call Trace: [ 4.113160] [ 4.113161] dump_stack_lvl+0x60/0x8c [ 4.113165] dump_stack+0x10/0x12 [ 4.113167] __might_resched.cold+0x13b/0x173 [ 4.113172] rt_spin_lock+0x5b/0xf0 [ 4.113179] get_page_from_freelist+0x20c/0x1610 [ 4.113208] __alloc_pages+0x25e/0x5e0 [ 4.113222] __stack_depot_save+0x3c0/0x4a0 [ 4.113228] kasan_save_stack+0x3a/0x50 [ 4.113322] __kasan_record_aux_stack+0xb6/0xc0 [ 4.113326] kasan_record_aux_stack+0xe/0x10 [ 4.113329] irq_work_queue_on+0x6a/0x1c0 [ 4.113333] pull_rt_task+0x631/0x6b0 [ 4.113343] do_balance_callbacks+0x56/0x80 [ 4.113346] __balance_callbacks+0x63/0x90 [ 4.113350] rt_mutex_setprio+0x349/0x880 [ 4.113366] rt_mutex_slowunlock+0x22a/0x4e0 [ 4.113377] rt_spin_unlock+0x49/0x80 [ 4.113380] uart_write+0x186/0x2b0 [ 4.113385] do_output_char+0x2e9/0x3a0 [ 4.113389] n_tty_write+0x306/0x800 [ 4.113413] file_tty_write.isra.0+0x2af/0x450 [ 4.113422] tty_write+0x22/0x30 [ 4.113425] new_sync_write+0x27c/0x3a0 [ 4.113446] vfs_write+0x3f7/0x5d0 [ 4.113451] ksys_write+0xd9/0x180 [ 4.113463] __x64_sys_write+0x43/0x50 [ 4.113466] do_syscall_64+0x44/0x90 [ 4.113469] entry_SYSCALL_64_after_hwframe+0x44/0xae On PREEMPT_RT kernel and KASAN is enabled. the kasan_record_aux_stack() may call alloc_pages(), and the rt-spinlock will be acquired, if currently in atomic context, will trigger warning. fix it by use kasan_record_aux_stack_noalloc() to avoid call alloc_pages(). Link: https://lkml.kernel.org/r/20220402142555.2699582-1-qiang1.zhang@intel.com Signed-off-by: Zqiang Cc: Andrey Ryabinin Cc: Alexander Potapenko Cc: Andrey Konovalov Cc: Dmitry Vyukov Signed-off-by: Andrew Morton --- diff --git a/kernel/irq_work.c b/kernel/irq_work.c index f7df715ec28e..7afa40fe5cc4 100644 --- a/kernel/irq_work.c +++ b/kernel/irq_work.c @@ -137,7 +137,7 @@ bool irq_work_queue_on(struct irq_work *work, int cpu) if (!irq_work_claim(work)) return false; - kasan_record_aux_stack(work); + kasan_record_aux_stack_noalloc(work); preempt_disable(); if (cpu != smp_processor_id()) {