From: Dan Carpenter <dan.carpenter@linaro.org>
Date: Wed, 3 Sep 2025 05:52:24 +0000 (+0300)
Subject: ALSA: rme32: Fix serialization in snd_rme32_capture_adat_open()
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=8409816b1eb306eb1f6137f83317fc756722d7d0;p=users%2Fhch%2Fmisc.git

ALSA: rme32: Fix serialization in snd_rme32_capture_adat_open()

We accidentally deleted the wrong line of code when we did the
conversion to guard() locks.  If the rme32->capture_substream has
already been set we should return -EBUSY.

Fixes: 8bb75ae244c5 ("ALSA: rme32: Use guard() for spin locks")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/aLfXmIQRFTXr5h8O@stanley.mountain
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

diff --git a/sound/pci/rme32.c b/sound/pci/rme32.c
index 123dddcb6972..ca9bbf554650 100644
--- a/sound/pci/rme32.c
+++ b/sound/pci/rme32.c
@@ -936,7 +936,7 @@ snd_rme32_capture_adat_open(struct snd_pcm_substream *substream)
         
 	scoped_guard(spinlock_irq, &rme32->lock) {
 		if (rme32->capture_substream != NULL)
-			spin_unlock_irq(&rme32->lock);
+			return -EBUSY;
 		rme32->capture_substream = substream;
 	}