From: Abhishek Shah Date: Thu, 13 Jul 2017 19:04:07 +0000 (+0530) Subject: net: ethernet: bgmac: Remove unnecessary 'return' from platform_bgmac_idm_write X-Git-Tag: v4.13-rc2~26^2~36^2~2 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=83a5c5af26ef8005caebd50ce62383a02c5bae82;p=users%2Fhch%2Fmisc.git net: ethernet: bgmac: Remove unnecessary 'return' from platform_bgmac_idm_write Return type for idm register write callback should be void as 'writel' API is used for write operation. However, there no need to have 'return' in this function. Signed-off-by: Abhishek Shah Reviewed-by: Oza Oza Reviewed-by: Ray Jui Reviewed-by: Scott Branden Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/broadcom/bgmac-platform.c b/drivers/net/ethernet/broadcom/bgmac-platform.c index 73aca97a96bc..1ca75dea1a77 100644 --- a/drivers/net/ethernet/broadcom/bgmac-platform.c +++ b/drivers/net/ethernet/broadcom/bgmac-platform.c @@ -50,7 +50,7 @@ static u32 platform_bgmac_idm_read(struct bgmac *bgmac, u16 offset) static void platform_bgmac_idm_write(struct bgmac *bgmac, u16 offset, u32 value) { - return writel(value, bgmac->plat.idm_base + offset); + writel(value, bgmac->plat.idm_base + offset); } static bool platform_bgmac_clk_enabled(struct bgmac *bgmac)