From: Rafał Miłecki <rafal@milecki.pl>
Date: Wed, 6 Jan 2021 09:09:15 +0000 (+0100)
Subject: net: dsa: print error on invalid port index
X-Git-Tag: howlett/maple/20220722_2~3823^2~403
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=8209f5bc3b67291a4e62ce1a1ce99c53b10e308a;p=users%2Fjedix%2Flinux-maple.git

net: dsa: print error on invalid port index

Looking for an -EINVAL all over the dsa code could take hours for
inexperienced DSA users.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/20210106090915.21439-1-zajec5@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---

diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c
index 183003e45762..01f21b0b379a 100644
--- a/net/dsa/dsa2.c
+++ b/net/dsa/dsa2.c
@@ -783,6 +783,8 @@ static int dsa_switch_parse_ports_of(struct dsa_switch *ds,
 			goto out_put_node;
 
 		if (reg >= ds->num_ports) {
+			dev_err(ds->dev, "port %pOF index %u exceeds num_ports (%zu)\n",
+				port, reg, ds->num_ports);
 			err = -EINVAL;
 			goto out_put_node;
 		}