From: Vincent Guittot Date: Thu, 4 Apr 2024 10:42:00 +0000 (+0200) Subject: PM: EM: fix wrong utilization estimation in em_cpu_energy() X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=8130b05c559d1aa83d0c8971b422ba0da18ef24a;p=users%2Fwilly%2Fpagecache.git PM: EM: fix wrong utilization estimation in em_cpu_energy() Commit 1b600da51073 ("PM: EM: Optimize em_cpu_energy() and remove division") has added back map_util_perf() in em_cpu_energy() computation which has been removed with the rework of scheduler/cpufreq interface. This is wrong because sugov_effective_cpu_perf() already takes care of mapping the utilization to a performance level. Fixes: 1b600da51073 ("PM: EM: Optimize em_cpu_energy() and remove division") Signed-off-by: Vincent Guittot Reviewed-by: Lukasz Luba Signed-off-by: Rafael J. Wysocki --- diff --git a/include/linux/energy_model.h b/include/linux/energy_model.h index 770755df852f1..70cd7258cd29f 100644 --- a/include/linux/energy_model.h +++ b/include/linux/energy_model.h @@ -245,7 +245,6 @@ static inline unsigned long em_cpu_energy(struct em_perf_domain *pd, * max utilization to the allowed CPU capacity before calculating * effective performance. */ - max_util = map_util_perf(max_util); max_util = min(max_util, allowed_cpu_cap); /*