From: Quytelda Kahja Date: Sat, 31 Mar 2018 06:08:52 +0000 (-0700) Subject: staging: ks7010: Change 'device_open_status' to a bool. X-Git-Tag: v4.18-rc1~83^2~772 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=8102f61d453edada4395bfc664538c3e11c6464d;p=users%2Fwilly%2Flinux.git staging: ks7010: Change 'device_open_status' to a bool. The 'device_open_status' member of 'struct ks_wlan_private' is only ever set to zero or one, so it makes more sense for it to be a bool instead of an int. Signed-off-by: Quytelda Kahja Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h index eb0c14e78bd2..efda12258d44 100644 --- a/drivers/staging/ks7010/ks_wlan.h +++ b/drivers/staging/ks7010/ks_wlan.h @@ -443,7 +443,7 @@ struct ks_wlan_private { unsigned int need_commit; /* for ioctl */ /* DeviceIoControl */ - int device_open_status; + bool device_open_status; atomic_t event_count; atomic_t rec_count; int dev_count; diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/drivers/staging/ks7010/ks_wlan_net.c index c4d94211b01b..9f9a51e96ab5 100644 --- a/drivers/staging/ks7010/ks_wlan_net.c +++ b/drivers/staging/ks7010/ks_wlan_net.c @@ -2875,10 +2875,9 @@ int ks_wlan_net_start(struct net_device *dev) priv = netdev_priv(dev); priv->mac_address_valid = false; + priv->device_open_status = true; priv->need_commit = 0; - priv->device_open_status = 1; - /* phy information update timer */ atomic_set(&update_phyinfo, 0); timer_setup(&update_phyinfo_timer, ks_wlan_update_phyinfo_timeout, 0); @@ -2908,7 +2907,7 @@ int ks_wlan_net_stop(struct net_device *dev) { struct ks_wlan_private *priv = netdev_priv(dev); - priv->device_open_status = 0; + priv->device_open_status = false; del_timer_sync(&update_phyinfo_timer); if (netif_running(dev))