From: David Oberhollenzer Date: Fri, 24 Jan 2020 22:57:40 +0000 (+0100) Subject: mtd-utils: Fix wrong argument to sizeof in nanddump X-Git-Tag: v2.1.2~6 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=7d40c1a1420bc95af20624aa22e254a8eb3356f0;p=mtd-utils.git mtd-utils: Fix wrong argument to sizeof in nanddump Some temporary buffers are allocated with "sizeof(pointer) * count" as size argument, which cannot possibly be correct. Assuming what was meant was "sizeof(pointer[0]) * count" makes sense in the context of how the buffers are used, but is actually pretty pointless, since the buffers are unsigend char. Signed-off-by: David Oberhollenzer --- diff --git a/nand-utils/nanddump.c b/nand-utils/nanddump.c index 62699e0..d7fc320 100644 --- a/nand-utils/nanddump.c +++ b/nand-utils/nanddump.c @@ -362,8 +362,8 @@ int main(int argc, char * const argv[]) return errmsg("mtd_get_dev_info failed"); /* Allocate buffers */ - oobbuf = xmalloc(sizeof(oobbuf) * mtd.oob_size); - readbuf = xmalloc(sizeof(readbuf) * mtd.min_io_size); + oobbuf = xmalloc(mtd.oob_size); + readbuf = xmalloc(mtd.min_io_size); if (noecc) { if (ioctl(fd, MTDFILEMODE, MTD_FILE_MODE_RAW) != 0) {