From: Christian Brauner <brauner@kernel.org>
Date: Fri, 12 Sep 2025 11:52:36 +0000 (+0200)
Subject: time: use ns_common_init()
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=7b0e2c83624b02a8a11f04f0581721d95ea6e4a6;p=users%2Fhch%2Fmisc.git

time: use ns_common_init()

Don't cargo-cult the same thing over and over.

Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Christian Brauner <brauner@kernel.org>
---

diff --git a/kernel/time/namespace.c b/kernel/time/namespace.c
index 667452768ed3..0be93d8f2896 100644
--- a/kernel/time/namespace.c
+++ b/kernel/time/namespace.c
@@ -88,22 +88,19 @@ static struct time_namespace *clone_time_ns(struct user_namespace *user_ns,
 		goto fail;
 
 	err = -ENOMEM;
-	ns = kmalloc(sizeof(*ns), GFP_KERNEL_ACCOUNT);
+	ns = kzalloc(sizeof(*ns), GFP_KERNEL_ACCOUNT);
 	if (!ns)
 		goto fail_dec;
 
-	refcount_set(&ns->ns.count, 1);
-
 	ns->vvar_page = alloc_page(GFP_KERNEL_ACCOUNT | __GFP_ZERO);
 	if (!ns->vvar_page)
 		goto fail_free;
 
-	err = ns_alloc_inum(&ns->ns);
+	err = ns_common_init(&ns->ns, &timens_operations, true);
 	if (err)
 		goto fail_free_page;
 
 	ns->ucounts = ucounts;
-	ns->ns.ops = &timens_operations;
 	ns->user_ns = get_user_ns(user_ns);
 	ns->offsets = old_ns->offsets;
 	ns->frozen_offsets = false;