From: Nishka Dasgupta Date: Thu, 15 Aug 2019 06:03:34 +0000 (+0530) Subject: mtd: spi-nor: hisi-sfc: Add of_node_put() before break X-Git-Tag: v5.4-rc1~87^2~12^2~5 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=7ae2227b1c1928cfc8220ca6383c757b185fcf32;p=linux.git mtd: spi-nor: hisi-sfc: Add of_node_put() before break Each iteration of for_each_available_child_of_node puts the previous node, but in the case of a break from the middle of the loop, there is no put, thus causing a memory leak. Hence add an of_node_put before the break. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta Signed-off-by: Tudor Ambarus --- diff --git a/drivers/mtd/spi-nor/hisi-sfc.c b/drivers/mtd/spi-nor/hisi-sfc.c index dea43ea3eea3..6dac9dd8bf42 100644 --- a/drivers/mtd/spi-nor/hisi-sfc.c +++ b/drivers/mtd/spi-nor/hisi-sfc.c @@ -401,6 +401,7 @@ static int hisi_spi_nor_register_all(struct hifmc_host *host) if (host->num_chip == HIFMC_MAX_CHIP_NUM) { dev_warn(dev, "Flash device number exceeds the maximum chipselect number\n"); + of_node_put(np); break; } }