From: Christian Brauner <brauner@kernel.org>
Date: Mon, 25 Nov 2024 14:10:03 +0000 (+0100)
Subject: firmware: avoid pointless reference count bump
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=7915f42453602697b402d8cbbeb7689166fb569b;p=users%2Fjedix%2Flinux-maple.git

firmware: avoid pointless reference count bump

The creds are allocated via prepare_kernel_cred() which has already
taken a reference.

Link: https://lore.kernel.org/r/20241125-work-cred-v2-7-68b9d38bb5b2@kernel.org
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Reviewed-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Christian Brauner <brauner@kernel.org>
---

diff --git a/drivers/base/firmware_loader/main.c b/drivers/base/firmware_loader/main.c
index a97fa36ee4bd6..cb0912ea3e627 100644
--- a/drivers/base/firmware_loader/main.c
+++ b/drivers/base/firmware_loader/main.c
@@ -911,7 +911,7 @@ _request_firmware(const struct firmware **firmware_p, const char *name,
 		ret = -ENOMEM;
 		goto out;
 	}
-	old_cred = override_creds(get_new_cred(kern_cred));
+	old_cred = override_creds(kern_cred);
 
 	ret = fw_get_filesystem_firmware(device, fw->priv, "", NULL);
 
@@ -943,7 +943,7 @@ _request_firmware(const struct firmware **firmware_p, const char *name,
 	} else
 		ret = assign_fw(fw, device);
 
-	put_cred(revert_creds(old_cred));
+	revert_creds(old_cred);
 	put_cred(kern_cred);
 
 out: