From: Pankaj Raghav Date: Thu, 22 Aug 2024 13:50:16 +0000 (+0200) Subject: xfs: expose block size in stat X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=79012cfa00b50ca80fb9f399f3c54b2185d728be;p=linux.git xfs: expose block size in stat For block size larger than page size, the unit of efficient IO is the block size, not the page size. Leaving stat() to report PAGE_SIZE as the block size causes test programs like fsx to issue illegal ranges for operations that require block size alignment (e.g. fallocate() insert range). Hence update the preferred IO size to reflect the block size in this case. This change is based on a patch originally from Dave Chinner.[1] [1] https://lwn.net/ml/linux-fsdevel/20181107063127.3902-16-david@fromorbit.com/ Signed-off-by: Pankaj Raghav Signed-off-by: Luis Chamberlain Link: https://lore.kernel.org/r/20240822135018.1931258-9-kernel@pankajraghav.com Acked-by: Darrick J. Wong Reviewed-by: Darrick J. Wong Reviewed-by: Dave Chinner Reviewed-by: Hannes Reinecke Reviewed-by: Daniel Gomez Reviewed-by: Matthew Wilcox (Oracle) Signed-off-by: Christian Brauner --- diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c index 1cdc8034f54d..6483b4c4cf35 100644 --- a/fs/xfs/xfs_iops.c +++ b/fs/xfs/xfs_iops.c @@ -567,7 +567,7 @@ xfs_stat_blksize( return 1U << mp->m_allocsize_log; } - return PAGE_SIZE; + return max_t(uint32_t, PAGE_SIZE, mp->m_sb.sb_blocksize); } STATIC int