From: David Woodhouse <dwmw2@infradead.org>
Date: Wed, 28 Apr 2021 19:47:42 +0000 (+0100)
Subject: Fix potential leak of 'domains' in parse_fortinet_xml_config()
X-Git-Tag: v8.20~242
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=786b420cf7a425aac2a24dd2d0145e530dbccd6e;p=users%2Fdwmw2%2Fopenconnect.git

Fix potential leak of 'domains' in parse_fortinet_xml_config()

Signed-off-by: David Woodhouse <dwmw2@infradead.org>
---

diff --git a/fortinet.c b/fortinet.c
index 057f6810..bad540c8 100644
--- a/fortinet.c
+++ b/fortinet.c
@@ -474,7 +474,6 @@ static int parse_fortinet_xml_config(struct openconnect_info *vpninfo, char *buf
 		domains->data[domains->pos-1] = '\0';
 		new_ip_info.domain = add_option_steal(&new_opts, "search", &domains->data);
 	}
-	buf_free(domains);
 
 	ret = install_vpn_opts(vpninfo, new_opts, &new_ip_info);
 	if (ret) {
@@ -488,8 +487,10 @@ static int parse_fortinet_xml_config(struct openconnect_info *vpninfo, char *buf
 	}
  out:
  	xmlFreeDoc(xml_doc);
+	buf_free(domains);
 	free(s);
 	free(s2);
+
 	return ret;
 }