From: Daniel Lenski <dlenski@gmail.com>
Date: Tue, 9 Jan 2018 08:01:15 +0000 (-0800)
Subject: Unfortunately, xmlNodeGetContent can't be avoided
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=76e88cdefd6b029d459c956d5d31075924b7e7df;p=users%2Fdwmw2%2Fopenconnect.git

Unfortunately, xmlNodeGetContent can't be avoided

I tested it, and see here: https://stackoverflow.com/a/10441292/20789

Signed-off-by: Daniel Lenski <dlenski@gmail.com>
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
---

diff --git a/auth-globalprotect.c b/auth-globalprotect.c
index 1e7c8549..0c151fec 100644
--- a/auth-globalprotect.c
+++ b/auth-globalprotect.c
@@ -127,7 +127,6 @@ static int parse_login_xml(struct openconnect_info *vpninfo, xmlNode *xml_node)
 		if (xml_node && !xmlnode_is_named(xml_node, "argument"))
 			goto err_out;
 		else if (xml_node) {
-			/* XX: Could we just use xml_node->content here? */
 			value = (char *)xmlNodeGetContent(xml_node);
 			if (value && (!value[0] || !strcmp(value, "(null)") || !strcmp(value, "-1"))) {
 				free(value);