From: Lukas Straub <lukasstraub2@web.de>
Date: Thu, 18 Mar 2021 04:11:52 +0000 (+0800)
Subject: net/colo-compare.c: Optimize removal of secondary packet
X-Git-Tag: v6.0.0-rc0~11^2~7
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=739128e43b6da3d0a48ec8551d94909dc5a8f3bc;p=users%2Fdwmw2%2Fqemu.git

net/colo-compare.c: Optimize removal of secondary packet

g_queue_remove needs to look up the list entry first, but we
already have it as result and can remove it directly with
g_queue_delete_link.

Signed-off-by: Lukas Straub <lukasstraub2@web.de>
Signed-off-by: Zhang Chen <chen.zhang@intel.com>
Reviewed-by: Zhang Chen <chen.zhang@intel.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---

diff --git a/net/colo-compare.c b/net/colo-compare.c
index 2e819ffedb..9d1ad99941 100644
--- a/net/colo-compare.c
+++ b/net/colo-compare.c
@@ -691,7 +691,7 @@ static void colo_compare_packet(CompareState *s, Connection *conn,
         if (result) {
             colo_release_primary_pkt(s, pkt);
             packet_destroy(result->data, NULL);
-            g_queue_remove(&conn->secondary_list, result->data);
+            g_queue_delete_link(&conn->secondary_list, result);
         } else {
             /*
              * If one packet arrive late, the secondary_list or