From: Michal Wajdeczko Date: Thu, 31 Jul 2025 19:33:36 +0000 (+0200) Subject: drm/xe/configfs: Keep default device config settings together X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=737a72d7e0231123ae3f1578845d9a23b6d02a60;p=users%2Fjedix%2Flinux-maple.git drm/xe/configfs: Keep default device config settings together For easier maintenance add a placeholder where we can keep all default device configuration settings in one place. Signed-off-by: Michal Wajdeczko Reviewed-by: John Harrison Reviewed-by: Lucas De Marchi Link: https://lore.kernel.org/r/20250731193339.179829-9-michal.wajdeczko@intel.com Signed-off-by: Lucas De Marchi --- diff --git a/drivers/gpu/drm/xe/xe_configfs.c b/drivers/gpu/drm/xe/xe_configfs.c index 7ad9fc65e21d..3fc01bef0114 100644 --- a/drivers/gpu/drm/xe/xe_configfs.c +++ b/drivers/gpu/drm/xe/xe_configfs.c @@ -97,6 +97,16 @@ struct xe_config_group_device { struct mutex lock; }; +static const struct xe_config_device device_defaults = { + .survivability_mode = false, + .engines_allowed = U64_MAX, +}; + +static void set_device_defaults(struct xe_config_device *config) +{ + *config = device_defaults; +} + struct engine_info { const char *cls; u64 mask; @@ -288,8 +298,7 @@ static struct config_group *xe_config_make_device_group(struct config_group *gro if (!dev) return ERR_PTR(-ENOMEM); - /* Default values */ - dev->config.engines_allowed = U64_MAX; + set_device_defaults(&dev->config); config_group_init_type_name(&dev->group, name, &xe_config_device_type); @@ -345,7 +354,7 @@ bool xe_configfs_get_survivability_mode(struct pci_dev *pdev) bool mode; if (!dev) - return false; + return device_defaults.survivability_mode; mode = dev->config.survivability_mode; config_group_put(&dev->group); @@ -389,7 +398,7 @@ u64 xe_configfs_get_engines_allowed(struct pci_dev *pdev) u64 engines_allowed; if (!dev) - return U64_MAX; + return device_defaults.engines_allowed; engines_allowed = dev->config.engines_allowed; config_group_put(&dev->group);