From: Markus Elfring Date: Tue, 24 Sep 2024 11:21:52 +0000 (+0200) Subject: regulator: Call of_node_put() only once in rzg2l_usb_vbus_regulator_probe() X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=7368e9f4e25bea507895bf194bd1c72d693840b2;p=users%2Fjedix%2Flinux-maple.git regulator: Call of_node_put() only once in rzg2l_usb_vbus_regulator_probe() An of_node_put(config.of_node) call was immediately used after a pointer check for a devm_regulator_register() call in this function implementation. Thus call such a function only once instead directly before the check. This issue was transformed by using the Coccinelle software. Signed-off-by: Markus Elfring Link: https://patch.msgid.link/f9d7a026-a67a-4164-80f4-578b1fbf71ac@web.de Signed-off-by: Mark Brown --- diff --git a/drivers/regulator/renesas-usb-vbus-regulator.c b/drivers/regulator/renesas-usb-vbus-regulator.c index 4eceb6b54497a..dec7cac5e8d59 100644 --- a/drivers/regulator/renesas-usb-vbus-regulator.c +++ b/drivers/regulator/renesas-usb-vbus-regulator.c @@ -49,13 +49,10 @@ static int rzg2l_usb_vbus_regulator_probe(struct platform_device *pdev) return dev_err_probe(dev, -ENODEV, "regulator node not found\n"); rdev = devm_regulator_register(dev, &rzg2l_usb_vbus_rdesc, &config); - if (IS_ERR(rdev)) { - of_node_put(config.of_node); + of_node_put(config.of_node); + if (IS_ERR(rdev)) return dev_err_probe(dev, PTR_ERR(rdev), "not able to register vbus regulator\n"); - } - - of_node_put(config.of_node); return 0; }