From: Michael Rubin Date: Tue, 8 Apr 2025 22:36:58 +0000 (+0000) Subject: staging: gpib: Removing typedef gpib_board_config X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=72ba314072a66774d5a90141ec99128c6bab033a;p=users%2Fjedix%2Flinux-maple.git staging: gpib: Removing typedef gpib_board_config Removing gpib_interface_t to adhere to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin Link: https://lore.kernel.org/r/20250408223659.187109-19-matchstick@neverthere.org Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/gpib/include/gpib_types.h b/drivers/staging/gpib/include/gpib_types.h index 9af5fdd1497ff..f4cb346b8a028 100644 --- a/drivers/staging/gpib/include/gpib_types.h +++ b/drivers/staging/gpib/include/gpib_types.h @@ -24,7 +24,6 @@ typedef struct gpib_interface_struct gpib_interface_t; struct gpib_board; -typedef struct gpib_board_config gpib_board_config_t; /* config parameters that are only used by driver attach functions */ struct gpib_board_config { @@ -56,7 +55,7 @@ struct gpib_interface_struct { /* name of board */ char *name; /* attach() initializes board and allocates resources */ - int (*attach)(struct gpib_board *board, const gpib_board_config_t *config); + int (*attach)(struct gpib_board *board, const struct gpib_board_config *config); /* detach() shuts down board and frees resources */ void (*detach)(struct gpib_board *board); /* read() should read at most 'length' bytes from the bus into @@ -292,7 +291,7 @@ struct gpib_board { struct gpib_pseudo_irq pseudo_irq; /* error dong autopoll */ atomic_t stuck_srq; - gpib_board_config_t config; + struct gpib_board_config config; /* Flag that indicates whether board is system controller of the bus */ unsigned master : 1; /* individual status bit */