From: Al Viro <viro@zeniv.linux.org.uk>
Date: Tue, 26 Aug 2025 20:53:42 +0000 (-0400)
Subject: open_detached_copy(): don't bother with mount_lock_hash()
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=71cf10ce4562ed7b18f3bd44a4e2dfafd0e84c50;p=users%2Fhch%2Fmisc.git

open_detached_copy(): don't bother with mount_lock_hash()

we are holding namespace_sem and a reference to root of tree;
iterating through that tree does not need mount_lock.  Neither
does the insertion into the rbtree of new namespace or incrementing
the mount count of that namespace.

Reviewed-by: Christian Brauner <brauner@kernel.org>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---

diff --git a/fs/namespace.c b/fs/namespace.c
index 7489c9c716c6..468ae0cb475e 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -3080,14 +3080,12 @@ static struct file *open_detached_copy(struct path *path, bool recursive)
 		return ERR_CAST(mnt);
 	}
 
-	lock_mount_hash();
 	for (p = mnt; p; p = next_mnt(p, mnt)) {
 		mnt_add_to_ns(ns, p);
 		ns->nr_mounts++;
 	}
 	ns->root = mnt;
 	mntget(&mnt->mnt);
-	unlock_mount_hash();
 	namespace_unlock();
 
 	mntput(path->mnt);