From: Wei Yongjun <weiyongjun1@huawei.com>
Date: Tue, 28 Apr 2020 15:06:50 +0000 (+0000)
Subject: staging: pi433: fix error return code in pi433_probe()
X-Git-Tag: v5.8-rc1~106^2~148
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=70458c20049f16a5512bf89ac5137f79d3049f91;p=linux.git

staging: pi433: fix error return code in pi433_probe()

Fix to return negative error code -ENOMEM from cdev alloc failed error
handling case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Link: https://lore.kernel.org/r/20200428150650.102340-1-weiyongjun1@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index 313d22f6210f..c8d0c63fdd1d 100644
--- a/drivers/staging/pi433/pi433_if.c
+++ b/drivers/staging/pi433/pi433_if.c
@@ -1230,6 +1230,7 @@ static int pi433_probe(struct spi_device *spi)
 	device->cdev = cdev_alloc();
 	if (!device->cdev) {
 		dev_dbg(device->dev, "allocation of cdev failed");
+		retval = -ENOMEM;
 		goto cdev_failed;
 	}
 	device->cdev->owner = THIS_MODULE;