From: Daniel Wagner <wagi@kernel.org>
Date: Tue, 8 Apr 2025 15:29:10 +0000 (+0200)
Subject: nvmet-fc: put ref when assoc->del_work is already scheduled
X-Git-Tag: nvme-6.15-2025-04-10^0
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=70289ae5cac4d3a39575405aaf63330486cea030;p=nvme.git

nvmet-fc: put ref when assoc->del_work is already scheduled

Do not leak the tgtport reference when the work is already scheduled.

Signed-off-by: Daniel Wagner <wagi@kernel.org>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Christoph Hellwig <hch@lst.de>
---

diff --git a/drivers/nvme/target/fc.c b/drivers/nvme/target/fc.c
index 61e9eea3bee4..7b50130f10f6 100644
--- a/drivers/nvme/target/fc.c
+++ b/drivers/nvme/target/fc.c
@@ -1073,7 +1073,8 @@ static void
 nvmet_fc_schedule_delete_assoc(struct nvmet_fc_tgt_assoc *assoc)
 {
 	nvmet_fc_tgtport_get(assoc->tgtport);
-	queue_work(nvmet_wq, &assoc->del_work);
+	if (!queue_work(nvmet_wq, &assoc->del_work))
+		nvmet_fc_tgtport_put(assoc->tgtport);
 }
 
 static bool