From: Matthew Wilcox (Oracle) Date: Thu, 26 May 2022 20:03:43 +0000 (-0400) Subject: buffer: Remove check for PageError X-Git-Tag: folio-6.0~41 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=6e8e79fc84435c159891182cddab8e7784e1b3b2;p=users%2Fwilly%2Fpagecache.git buffer: Remove check for PageError If a buffer is completed with an error, its uptodate flag will be clear, so the page_uptodate variable will have been set to 0. There's no need to check PageError here. Signed-off-by: Matthew Wilcox (Oracle) --- diff --git a/fs/buffer.c b/fs/buffer.c index 276769d3715a8..a0214e3f90d36 100644 --- a/fs/buffer.c +++ b/fs/buffer.c @@ -282,10 +282,10 @@ static void end_buffer_async_read(struct buffer_head *bh, int uptodate) spin_unlock_irqrestore(&first->b_uptodate_lock, flags); /* - * If none of the buffers had errors and they are all - * uptodate then we can set the page uptodate. + * If all of the buffers are uptodate then we can set the page + * uptodate. */ - if (page_uptodate && !PageError(page)) + if (page_uptodate) SetPageUptodate(page); unlock_page(page); return;