From: Minwoo Im Date: Sun, 1 Jul 2018 13:58:05 +0000 (+0900) Subject: nvme-cli: print firmware activation notices support bit to id_ctrl X-Git-Tag: v1.6~7 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=6b3011b0512d252d0cbfb9331e4610b8da8e2c90;p=users%2Fsagi%2Fnvme-cli.git nvme-cli: print firmware activation notices support bit to id_ctrl It's now currently printing the OAES(Optional Asynchronous Events Supported) field in identify controller data structure without [9] firmware activation notices field in case of human-readable format. Print it out by updating the reserved bit field. Signed-off-by: Minwoo Im Signed-off-by: Keith Busch --- diff --git a/nvme-print.c b/nvme-print.c index 20c24587..daf29295 100644 --- a/nvme-print.c +++ b/nvme-print.c @@ -94,12 +94,15 @@ static void show_nvme_id_ctrl_cmic(__u8 cmic) static void show_nvme_id_ctrl_oaes(__le32 ctrl_oaes) { __u32 oaes = le32_to_cpu(ctrl_oaes); - __u32 rsvd0 = (oaes & 0xFFFFFE00) >> 9; + __u32 rsvd0 = (oaes & 0xFFFFFC00) >> 10; __u32 nace = (oaes & 0x100) >> 8; + __u32 fan = (oaes & 0x200) >> 9; __u32 rsvd1 = oaes & 0xFF; if (rsvd0) - printf(" [31:9] : %#x\tReserved\n", rsvd0); + printf(" [31:10] : %#x\tReserved\n", rsvd0); + printf(" [9:9] : %#x\tFirmware Activation Notices %sSupported\n", + fan, fan ? "" : "Not "); printf(" [8:8] : %#x\tNamespace Attribute Changed Event %sSupported\n", nace, nace ? "" : "Not "); if (rsvd1)