From: Vasily Averin <vvs@virtuozzo.com>
Date: Thu, 8 Nov 2018 03:36:23 +0000 (-0500)
Subject: ext4: fix buffer leak in __ext4_read_dirblock() on error path
X-Git-Tag: v4.14.82~35
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=68b908750ea4cb285aef4f58ed89056e3b0039db;p=users%2Fjedix%2Flinux-maple.git

ext4: fix buffer leak in __ext4_read_dirblock() on error path

commit de59fae0043f07de5d25e02ca360f7d57bfa5866 upstream.

Fixes: dc6982ff4db1 ("ext4: refactor code to read directory blocks ...")
Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org # 3.9
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index cfa0dc2d97cd4..4e301b0cdfb53 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -125,6 +125,7 @@ static struct buffer_head *__ext4_read_dirblock(struct inode *inode,
 	if (!is_dx_block && type == INDEX) {
 		ext4_error_inode(inode, func, line, block,
 		       "directory leaf block found instead of index block");
+		brelse(bh);
 		return ERR_PTR(-EFSCORRUPTED);
 	}
 	if (!ext4_has_metadata_csum(inode->i_sb) ||