From: Hongbo Li Date: Wed, 28 Aug 2024 12:32:19 +0000 (+0800) Subject: net: prefer strscpy over strcpy X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=68016b997222c9f866912f6911815105ed2ce473;p=users%2Fjedix%2Flinux-maple.git net: prefer strscpy over strcpy The deprecated helper strcpy() performs no bounds checking on the destination buffer. This could result in linear overflows beyond the end of the buffer, leading to all kinds of misbehaviors. The safe replacement is strscpy() [1]. Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy [1] Signed-off-by: Hongbo Li Signed-off-by: Jakub Kicinski --- diff --git a/net/core/dev.c b/net/core/dev.c index 63987b8b7c853..932d67b975f50 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -11143,7 +11143,7 @@ struct net_device *alloc_netdev_mqs(int sizeof_priv, const char *name, if (!dev->ethtool) goto free_all; - strcpy(dev->name, name); + strscpy(dev->name, name); dev->name_assign_type = name_assign_type; dev->group = INIT_NETDEV_GROUP; if (!dev->ethtool_ops)