From: Sunil Khatri Date: Wed, 31 Jul 2024 08:06:15 +0000 (+0530) Subject: drm/amdgpu: do not call insert_nop fn for zero count X-Git-Tag: configfs-6.13-2024-11-19~386^2~17^2~231 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=67c4ca9f794951482c54a7006c8b3c367d6c3efc;p=users%2Fhch%2Fconfigfs.git drm/amdgpu: do not call insert_nop fn for zero count Do not make a function call for zero size NOP as it does not add anything in the ring and is unnecessary function call. Reviewed-by: Christian König Signed-off-by: Sunil Khatri Signed-off-by: Alex Deucher --- diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c index ad49cecb20b8..0d72d2cbb64b 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c @@ -145,7 +145,9 @@ void amdgpu_ring_commit(struct amdgpu_ring *ring) count = ring->funcs->align_mask + 1 - (ring->wptr & ring->funcs->align_mask); count %= ring->funcs->align_mask + 1; - ring->funcs->insert_nop(ring, count); + + if (count != 0) + ring->funcs->insert_nop(ring, count); mb(); amdgpu_ring_set_wptr(ring);