From: Greg Kurz Date: Wed, 7 Jun 2017 17:16:52 +0000 (+0200) Subject: pnv_core: drop reference on ICPState object during CPU realization X-Git-Tag: v2.10.0-rc0~136^2~8 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=67b544d65f92b9987bc05b9da7e6269af48f1b69;p=users%2Fdwmw2%2Fqemu.git pnv_core: drop reference on ICPState object during CPU realization Similarly to what was done to spapr with commit 249127d0dfeb, this patch ensures that we don't keep an extra reference on the ICPState object. Also since the object was just created and not reparented yet, the call to object_property_add_child() should never fail: let's pass &error_abort to make this clear. Signed-off-by: Greg Kurz Reviewed-by: Cédric Le Goater Signed-off-by: David Gibson --- diff --git a/hw/ppc/pnv_core.c b/hw/ppc/pnv_core.c index 1b7ec70f03..e8a9a94d5a 100644 --- a/hw/ppc/pnv_core.c +++ b/hw/ppc/pnv_core.c @@ -119,7 +119,8 @@ static void pnv_core_realize_child(Object *child, XICSFabric *xi, Error **errp) Object *obj; obj = object_new(TYPE_PNV_ICP); - object_property_add_child(OBJECT(cpu), "icp", obj, NULL); + object_property_add_child(OBJECT(cpu), "icp", obj, &error_abort); + object_unref(obj); object_property_add_const_link(obj, "xics", OBJECT(xi), &error_abort); object_property_set_bool(obj, true, "realized", &local_err); if (local_err) {