From: Daniel Wagner <dwagner@suse.de>
Date: Mon, 1 Aug 2022 12:22:17 +0000 (+0200)
Subject: nvme: Do not print error message in collect_effects_log helper
X-Git-Tag: v2.1~2^2
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=666ff8c15da3a3e00b4386944a2b6792ce745c0e;p=users%2Fsagi%2Fnvme-cli.git

nvme: Do not print error message in collect_effects_log helper

We print error and status on the top level, so no need to print it a
helper.

Signed-off-by: Daniel Wagner <dwagner@suse.de>
---

diff --git a/nvme.c b/nvme.c
index 61f10fca..0bc88766 100644
--- a/nvme.c
+++ b/nvme.c
@@ -600,17 +600,12 @@ static int collect_effects_log(int fd, enum nvme_csi csi,
 	node->csi = csi;
 
 	err = nvme_get_log_cmd_effects(fd, csi, &node->effects);
-	if (!err) {
-		list_add(list, &node->node);
+	if (err) {
+		free(node);
 		return err;
 	}
-	else if (err > 0)
-		nvme_show_status(err);
-	else
-		fprintf(stderr, "effects log page: %s\n", nvme_strerror(errno));
-
-	free(node);
-	return err;
+	list_add(list, &node->node);
+	return 0;
 }
 
 static int get_effects_log(int argc, char **argv, struct command *cmd, struct plugin *plugin)