From: David Woodhouse <David.Woodhouse@intel.com>
Date: Wed, 26 Sep 2012 19:04:28 +0000 (+0100)
Subject: Fix token serial number matching when trying to find hidden PKCS#11 key
X-Git-Tag: v4.08~23
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=644d9622e91e6f6a2bad4cf694b6e26cec0c5828;p=users%2Fdwmw2%2Fopenconnect.git

Fix token serial number matching when trying to find hidden PKCS#11 key

Spotted by Coverity.

Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
---

diff --git a/gnutls.c b/gnutls.c
index d9e550d8..3513ccb1 100644
--- a/gnutls.c
+++ b/gnutls.c
@@ -1114,7 +1114,7 @@ static int load_certificate(struct openconnect_info *vpninfo)
 				}
 			}
 			if (!token->serialNumber[0]) {
-				s = sizeof(token->serialNumber + 1);
+				s = sizeof(token->serialNumber) + 1;
 				if (!gnutls_pkcs11_obj_get_info(crt, GNUTLS_PKCS11_OBJ_TOKEN_SERIAL,
 								buf, &s)) {
 					s--;