From: Anandu Krishnan E Date: Fri, 10 Jan 2025 13:42:37 +0000 (+0000) Subject: misc: fastrpc: Deregister device nodes properly in error scenarios X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=637c20002dc8c347001292664055bfbf56544ec6;p=users%2Fjedix%2Flinux-maple.git misc: fastrpc: Deregister device nodes properly in error scenarios During fastrpc_rpmsg_probe, if secure device node registration succeeds but non-secure device node registration fails, the secure device node deregister is not called during error cleanup. Add proper exit paths to ensure proper cleanup in case of error. Fixes: 3abe3ab3cdab ("misc: fastrpc: add secure domain support") Cc: stable@kernel.org Signed-off-by: Anandu Krishnan E Signed-off-by: Srinivas Kandagatla Link: https://lore.kernel.org/r/20250110134239.123603-2-srinivas.kandagatla@linaro.org Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index dd766c8018e4a..b116ed068b997 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -2346,7 +2346,7 @@ static int fastrpc_rpmsg_probe(struct rpmsg_device *rpdev) err = fastrpc_device_register(rdev, data, false, domains[domain_id]); if (err) - goto fdev_error; + goto populate_error; break; default: err = -EINVAL;