From: David Woodhouse Date: Thu, 31 Jul 2014 22:03:00 +0000 (+0100) Subject: Fix quoting on network comparisons X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=6201ebd5e38ce185798407e0ca5262b51ce53c9a;p=users%2Fdwmw2%2Fvpnc-scripts.git Fix quoting on network comparisons Spotted by Marcus Müller Signed-off-by: David Woodhouse --- diff --git a/vpnc-script b/vpnc-script index 79cf6e2..dfbad36 100755 --- a/vpnc-script +++ b/vpnc-script @@ -636,7 +636,7 @@ do_connect() { eval NETWORK="\${CISCO_SPLIT_INC_${i}_ADDR}" eval NETMASK="\${CISCO_SPLIT_INC_${i}_MASK}" eval NETMASKLEN="\${CISCO_SPLIT_INC_${i}_MASKLEN}" - if [ $NETWORK != "0.0.0.0" ]; then + if [ "$NETWORK" != "0.0.0.0" ]; then set_network_route "$NETWORK" "$NETMASK" "$NETMASKLEN" else set_default_route @@ -683,7 +683,7 @@ do_disconnect() { eval NETWORK="\${CISCO_SPLIT_INC_${i}_ADDR}" eval NETMASK="\${CISCO_SPLIT_INC_${i}_MASK}" eval NETMASKLEN="\${CISCO_SPLIT_INC_${i}_MASKLEN}" - if [ $NETWORK != "0.0.0.0" ]; then + if [ "$NETWORK" != "0.0.0.0" ]; then # FIXME: This doesn't restore previously overwritten # routes. del_network_route "$NETWORK" "$NETMASK" "$NETMASKLEN"