From: Shuah Khan (Samsung OSG) <shuah@kernel.org>
Date: Fri, 4 May 2018 00:23:49 +0000 (-0600)
Subject: selftests: ipc: return Kselftest Skip code for skipped tests
X-Git-Tag: pci-v4.18-changes-2~20^2~22
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=6004881fa0730fed08a2a719a81efba6003d9d36;p=users%2Fdwmw2%2Flinux.git

selftests: ipc: return Kselftest Skip code for skipped tests

When ipc test is skipped because of unmet dependencies and/or
unsupported configuration, it exits with error which is treated as
a fail by the Kselftest framework. This leads to false negative
result even when the test could not be run.

Change it to return kselftest skip code when a test gets skipped to
clearly report that the test could not be run.

Change it to use ksft_exit_skip() when the test is skipped.

Signed-off-by: Shuah Khan (Samsung OSG) <shuah@kernel.org>
---

diff --git a/tools/testing/selftests/ipc/msgque.c b/tools/testing/selftests/ipc/msgque.c
index ee9382bdfadc8..dac927e823363 100644
--- a/tools/testing/selftests/ipc/msgque.c
+++ b/tools/testing/selftests/ipc/msgque.c
@@ -196,10 +196,9 @@ int main(int argc, char **argv)
 	int msg, pid, err;
 	struct msgque_data msgque;
 
-	if (getuid() != 0) {
-		printf("Please run the test as root - Exiting.\n");
-		return ksft_exit_fail();
-	}
+	if (getuid() != 0)
+		return ksft_exit_skip(
+				"Please run the test as root - Exiting.\n");
 
 	msgque.key = ftok(argv[0], 822155650);
 	if (msgque.key == -1) {